David Hendricks has posted comments on this change. ( https://review.coreboot.org/23057 )
Change subject: buspirate_spi: Add support for variable serial speeds ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
Looks pretty good. I don't have a bus pirate though, but I pointed out this patch on IRC so hopefully somebody more familiar with the hardware can chime in here.
https://review.coreboot.org/#/c/23057/1/buspirate_spi.c File buspirate_spi.c:
https://review.coreboot.org/#/c/23057/1/buspirate_spi.c@201 PS1, Line 201: if ((ret = serialport_config(sp_fd, 115200))) nit: extra parens
https://review.coreboot.org/#/c/23057/1/buspirate_spi.c@262 PS1, Line 262: serialspeeds[i].name You could also use ARRAY_SIZE(serialspeeds) as your limit so that you don't need the terminator at the end of serialspeeds.
-
David Hendricks (Code Review)