Looks pretty good. I don't have a bus pirate though, but I pointed out this patch on IRC so hopefully somebody more familiar with the hardware can chime in here.

Patch set 1:Code-Review +1

View Change

2 comments:

• File buspirate_spi.c:

  • Patch Set #1, Line 201: if ((ret = serialport_config(sp_fd, 115200)))

    nit: extra parens

  • Patch Set #1, Line 262: serialspeeds[i].name

    You could also use ARRAY_SIZE(serialspeeds) as your limit so that you don't need the terminator at the end of serialspeeds.

To view, visit change 23057. To unsubscribe, or for help writing mail filters, visit settings.