Attention is currently required from: Light. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62726 )
Change subject: serprog.c: Fixed passed null value when expectingn nonnull ......................................................................
Patch Set 1: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62726/comment/adab96d1_0a7fd1b0 PS1, Line 7: n Remove extra `n` at the end
https://review.coreboot.org/c/flashrom/+/62726/comment/f6fecfb0_13595276 PS1, Line 7: Fixed passed null value when expectingn nonnull How about:
Avoid calling memcpy with NULL pointer arguments
https://review.coreboot.org/c/flashrom/+/62726/comment/dbde3c41_f847a680 PS1, Line 11: Just added a check before : memcpy for parms==NULL. How about:
Still, add a NULL check before calling memcpy to be safe.
File serprog.c:
https://review.coreboot.org/c/flashrom/+/62726/comment/06ec9096_6cdb7ffd PS1, Line 294: if Please add a space after `if`
https://review.coreboot.org/c/flashrom/+/62726/comment/ba31a13e_e7ee09d3 PS1, Line 295: memcpy(&(sp[1]), parms, parmlen); We use tabs for indentation, and a tab is 8 characters wide. Please refer to https://flashrom.org/Development_Guidelines#Coding_style
-
Angel Pons (Code Review)