Attention is currently required from: Light.

Patch set 1:Code-Review +1

View Change

5 comments:

• Commit Message:

  • Patch Set #1, Line 7: n

    Remove extra `n` at the end

  • Patch Set #1, Line 7: Fixed passed null value when expectingn nonnull

    How about:

     Avoid calling memcpy with NULL pointer arguments

  • Patch Set #1, Line 11:

    Just added a check before
    memcpy for parms==NULL.
    

    How about:

     Still, add a NULL check before calling memcpy to be safe.

• File serprog.c:

  • Patch Set #1, Line 294: if

    Please add a space after `if`

  • Patch Set #1, Line 295: memcpy(&(sp[1]), parms, parmlen);

    We use tabs for indentation, and a tab is 8 characters wide. Please refer to https://flashrom.org/Development_Guidelines#Coding_style

To view, visit change 62726. To unsubscribe, or for help writing mail filters, visit settings.