Attention is currently required from: Nico Huber, Angel Pons, Light.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 )
Change subject: ich_descriptors.c: Assert unsigned types >=0 on to prevent underflow error
......................................................................
Patch Set 12: Code-Review+1
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62764/comment/716ae958_c48dbf18
PS6, Line 507: assert(j >= 12);
Yeah I am okay with making it explicit :)
One difference that I see, is for Sunrise Point: `num_regions` is 10 (assigned at line 492 in current patchset). So in initial version the loop starts with j=10, after this patch it starts with j=12.
I understand about underflow and undefined behaviour, looks like it's correct to start loop with j=12.
I am curious, what was printed for Sunrise Point for j=10,11 , was that printing garbage?
Otherwise, looks good! What do you think Nico?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5921cc571f3dca5188ca1973dba6ececbcbe2f39
Gerrit-Change-Number: 62764
Gerrit-PatchSet: 12
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Light
aarya.chaumal@gmail.com
Gerrit-Comment-Date: Sat, 26 Mar 2022 06:50:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Light
aarya.chaumal@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment