Attention is currently required from: Nico Huber, Angel Pons, Light.

Patch set 12:Code-Review +1

View Change

1 comment:

• File ich_descriptors.c:

  • Patch Set #6, Line 507: assert(j >= 12);

    Yeah I am okay with making it explicit :)

    One difference that I see, is for Sunrise Point: `num_regions` is 10 (assigned at line 492 in current patchset). So in initial version the loop starts with j=10, after this patch it starts with j=12.
    I understand about underflow and undefined behaviour, looks like it's correct to start loop with j=12.
    I am curious, what was printed for Sunrise Point for j=10,11 , was that printing garbage?

    Otherwise, looks good! What do you think Nico?

To view, visit change 62764. To unsubscribe, or for help writing mail filters, visit settings.