Change in flashrom[master]: [v4, 5/6] Add the hidden-from-probing chips category and make KB9012 h...

Nico Huber has posted comments on this change. ( https://review.coreboot.org/23262 ) Change subject: [v4,5/6] Add the hidden-from-probing chips category and make KB9012 hidden ...................................................................... Patch Set 1: (1 comment) This should be done before adding the EDI driver. AFAIR, Paul had something more flexible in mind: Instead of the `hidden` flag a grouping of the chips. Basically the same what you did but instead of 0/1 values a default of JEDEC and alternatively EDI and whatever might come in the future. How about that? https://review.coreboot.org/#/c/23262/1/flashrom.c File flashrom.c: https://review.coreboot.org/#/c/23262/1/flashrom.c@1213 PS1, Line 1213: if (!((!chip_to_probe && !chip->hidden) || This can be written much cleaner without multiple negations, IMO: if (!chip_to_probe && chip->hidden) continue; if (chip_to_probe && /* original condition ... */ You wouldn't need a comment then to explain what you do, because it would be obvious. But let's discuss the "hidden vs. groups" thing, first. -- To view, visit https://review.coreboot.org/23262 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89a53ccaef2791a2ac32904d7ab813da7478a6f0 Gerrit-Change-Number: 23262 Gerrit-PatchSet: 1 Gerrit-Owner: Mike Banon <mikebdp2@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Kocialkowski <contact@paulk.fr> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Fri, 26 Jan 2018 16:22:00 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
participants (1)
-
Nico Huber (Code Review)