This should be done before adding the EDI driver.

AFAIR, Paul had something more flexible in mind: Instead of the
`hidden` flag a grouping of the chips. Basically the same what you
did but instead of 0/1 values a default of JEDEC and alternatively
EDI and whatever might come in the future. How about that?

View Change

1 comment:

• File flashrom.c:

  • Patch Set #1, Line 1213: if (!((!chip_to_probe && !chip->hidden) ||

    This can be written much cleaner without multiple negations, IMO:

        if (!chip_to_probe && chip->hidden)
                continue;
        if (chip_to_probe && /* original condition ... */

    You wouldn't need a comment then to explain what you do, because
    it would be obvious.

    But let's discuss the "hidden vs. groups" thing, first.

To view, visit change 23262. To unsubscribe, or for help writing mail filters, visit settings.