Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57326 )
Change subject: tests: Add tests to read from chip ......................................................................
Patch Set 4:
(2 comments)
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/57326/comment/ad5068e5_ded42cc4 PS3, Line 185: len
This is `nmemb` (according to manpage). `len` is easy to confuse with […]
Done
https://review.coreboot.org/c/flashrom/+/57326/comment/b8d17273_fe4e306a PS3, Line 188: size * len
This should return just `len` (actually `nmemb`). It only works because […]
Thank you! I would probably discover this at some point later for some other future test, and it would take much longer time to debug/understand where the mistake is.
-
Anastasia Klimchuk (Code Review)