Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
View Change
2 comments:
File tests/tests.c:
Patch Set #3, Line 185: len
This is `nmemb` (according to manpage). `len` is easy to confuse with […]
Done
Patch Set #3, Line 188: size * len
This should return just `len` (actually `nmemb`). It only works because […]
Thank you! I would probably discover this at some point later for some other future test, and it would take much longer time to debug/understand where the mistake is.
To view, visit change 57326. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia57781ebc670c7bd6197e56fe8a20651a425c756
Gerrit-Change-Number: 57326
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Nico Huber <nico.h@gmx.de>
Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Comment-Date: Tue, 14 Sep 2021 05:41:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Gerrit-MessageType: comment