Attention is currently required from: Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52595 )
Change subject: mec1308.c: Extract params check into a function ......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52595/comment/03744c05_fc2789d5 PS1, Line 9: This allows char *p to become a local variable in
I can explain why I thought it's a good idea to make it wider: so that commit message spans less lin […]
Hmm, probably a good point. Personally, I don't notice such things much. Maybe because I use rather large screens, usually I feel limited by the amount of windows I can have side-by-side. Also, I rarely use laptops with degraded 16:9 screens.
Anyway, if you wanted to change it, I fully agree. Just wanted to make sure nobody feels forced to make their lines longer :)
-
Nico Huber (Code Review)