Attention is currently required from: Anastasia Klimchuk.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 9: This allows char *p to become a local variable in
I can explain why I thought it's a good idea to make it wider: so that commit message spans less lin […]
Hmm, probably a good point. Personally, I don't notice such things
much. Maybe because I use rather large screens, usually I feel limited
by the amount of windows I can have side-by-side. Also, I rarely use
laptops with degraded 16:9 screens.
Anyway, if you wanted to change it, I fully agree. Just wanted to
make sure nobody feels forced to make their lines longer :)
To view, visit change 52595. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If5be7709e93233a2e7ea9133de50382d2524a55f
Gerrit-Change-Number: 52595
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-CC: Victor Ding <victording@google.com>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Comment-Date: Tue, 27 Apr 2021 10:27:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h@gmx.de>
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment