Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66654 )
Change subject: tree: Change signature of extract_programmer_param_str() ......................................................................
Patch Set 6:
(1 comment)
File atavia.c:
https://review.coreboot.org/c/flashrom/+/66654/comment/6530899e_7c92b514 PS6, Line 148: NULL For any future patches... If this should eventually not be a NULL pointer, at the very least please define a temporary macro to keep track of all instances of this. After all the necessary changes are done, the temporary macro should no longer be used anywhere and can be dropped.
``` /* Temporary macro to keep track of things, will eventually be dropped. */ #define NULL_PROGRAMMER_CFG_FIXME NULL ```
Then, this line would look like this until it's fixed:
``` char *arg = extract_programmer_param_str(NULL_PROGRAMMER_CFG_FIXME, "offset"); ```