Attention is currently required from: Edward O'Callaghan.

View Change

1 comment:

• File atavia.c:

  • Patch Set #6, Line 148: NULL

    For any future patches... If this should eventually not be a NULL pointer, at the very least please define a temporary macro to keep track of all instances of this. After all the necessary changes are done, the temporary macro should no longer be used anywhere and can be dropped.

    ```
    /* Temporary macro to keep track of things, will eventually be dropped. */
    #define NULL_PROGRAMMER_CFG_FIXME NULL
    ```

    Then, this line would look like this until it's fixed:

    ```
    char *arg = extract_programmer_param_str(NULL_PROGRAMMER_CFG_FIXME, "offset");
    ```

To view, visit change 66654. To unsubscribe, or for help writing mail filters, visit settings.