Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/31013
Change subject: layout: Add missing stdbool.h include ......................................................................
layout: Add missing stdbool.h include
Change-Id: I9a413d491038b29c832011a738f3b49e029dcf6f Signed-off-by: Nico Huber nico.h@gmx.de --- M layout.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/31013/1
diff --git a/layout.h b/layout.h index 61311bc..a10cbb4 100644 --- a/layout.h +++ b/layout.h @@ -23,6 +23,7 @@
#include <stddef.h> #include <stdint.h> +#include <stdbool.h>
/* Types and macros regarding the maximum flash space size supported by generic code. */ typedef uint32_t chipoff_t; /* Able to store any addressable offset within a supported flash memory. */
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31013 )
Change subject: layout: Add missing stdbool.h include ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31013 )
Change subject: layout: Add missing stdbool.h include ......................................................................
Patch Set 1: Code-Review+1
Hello Angel Pons, Paul Menzel, Thomas Heijligen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/31013
to look at the new patch set (#2).
Change subject: layout: Add missing stdbool.h include ......................................................................
layout: Add missing stdbool.h include
Change-Id: I9a413d491038b29c832011a738f3b49e029dcf6f Signed-off-by: Nico Huber nico.h@gmx.de --- M layout.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/13/31013/2
Philippe Mathieu-Daudé has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31013 )
Change subject: layout: Add missing stdbool.h include ......................................................................
Patch Set 2: Code-Review+1
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/31013 )
Change subject: layout: Add missing stdbool.h include ......................................................................
layout: Add missing stdbool.h include
Change-Id: I9a413d491038b29c832011a738f3b49e029dcf6f Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/31013 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Philippe Mathieu-Daudé f4bug@amsat.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net --- M layout.h 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Philippe Mathieu-Daudé: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/layout.h b/layout.h index eb54a4f..770224b 100644 --- a/layout.h +++ b/layout.h @@ -23,6 +23,7 @@
#include <stddef.h> #include <stdint.h> +#include <stdbool.h>
/* Types and macros regarding the maximum flash space size supported by generic code. */ typedef uint32_t chipoff_t; /* Able to store any addressable offset within a supported flash memory. */
-
Angel Pons (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)
-
Philippe Mathieu-Daudé (Code Review)