Change in ...flashrom[master]: layout.c: Remove unused variable
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/31243 Change subject: layout.c: Remove unused variable ...................................................................... layout.c: Remove unused variable Change-Id: I0c0c085999a12987376d75825fcf43e788a55a4b Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> --- M layout.c 1 file changed, 0 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/31243/1 diff --git a/layout.c b/layout.c index fa66238..e10bb73 100644 --- a/layout.c +++ b/layout.c @@ -161,7 +161,6 @@ int process_include_args(struct flashrom_layout *const l) { int i; - unsigned int found = 0; if (num_include_args == 0) return 0; @@ -180,7 +179,6 @@ include_args[i]); return 1; } - found++; } msg_ginfo("Using region%s: \"%s\"", num_include_args > 1 ? "s" : "", -- To view, visit https://review.coreboot.org/c/flashrom/+/31243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c0c085999a12987376d75825fcf43e788a55a4b Gerrit-Change-Number: 31243 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-MessageType: newchange
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31243 ) Change subject: layout.c: Remove unused variable ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/flashrom/+/31243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c0c085999a12987376d75825fcf43e788a55a4b Gerrit-Change-Number: 31243 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 05 Feb 2019 16:35:42 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/31243 ) Change subject: layout.c: Remove unused variable ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/flashrom/+/31243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c0c085999a12987376d75825fcf43e788a55a4b Gerrit-Change-Number: 31243 Gerrit-PatchSet: 1 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-Comment-Date: Tue, 05 Feb 2019 17:25:05 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/31243 ) Change subject: layout.c: Remove unused variable ...................................................................... layout.c: Remove unused variable Change-Id: I0c0c085999a12987376d75825fcf43e788a55a4b Signed-off-by: Arthur Heymans <arthur@aheymans.xyz> Reviewed-on: https://review.coreboot.org/c/31243 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net> Reviewed-by: Angel Pons <th3fanbus@gmail.com> --- M layout.c 1 file changed, 0 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved diff --git a/layout.c b/layout.c index fa66238..e10bb73 100644 --- a/layout.c +++ b/layout.c @@ -161,7 +161,6 @@ int process_include_args(struct flashrom_layout *const l) { int i; - unsigned int found = 0; if (num_include_args == 0) return 0; @@ -180,7 +179,6 @@ include_args[i]); return 1; } - found++; } msg_ginfo("Using region%s: \"%s\"", num_include_args > 1 ? "s" : "", -- To view, visit https://review.coreboot.org/c/flashrom/+/31243 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I0c0c085999a12987376d75825fcf43e788a55a4b Gerrit-Change-Number: 31243 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur@aheymans.xyz> Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Nico Huber <nico.h@gmx.de> Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-MessageType: merged
participants (4)
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Nico Huber (Code Review)
-
Paul Menzel (Code Review)