Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73039 )
Change subject: flashrom: rewrite flashbuses_to_text() ......................................................................
Patch Set 7:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/73039/comment/5973ee55_31605de3 PS6, Line 17: `printf()`
I thought that's undefined behaviour, handling null in printf?
Oh, my bad. I just tested it on my GNU implementation, which produces fancy `(null)` output. In C99 standard, the behavior of `printf()` when passed a null pointer argument is undefined.
So, this patchset handles these cases by `use the ? symbol`. IMO, incomplete output is not a critical error in this case. Better, than aborting.
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/73039/comment/b58793d9_94d383e6 PS5, Line 948: if (bustype & (1 << i))
Looks good! I was a bit confused where is the code, but realised it's only in the comment for now, n […]
Done
-
Alexander Goncharov (Code Review)