Attention is currently required from: Edward O'Callaghan, Angel Pons, Anastasia Klimchuk.

View Change

2 comments:

• Commit Message:

  • Patch Set #6, Line 17: `printf()`

    I thought that's undefined behaviour, handling null in printf?

    Oh, my bad. I just tested it on my GNU implementation, which produces fancy `(null)` output. In C99 standard, the behavior of `printf()` when passed a null pointer argument is undefined.

    So, this patchset handles these cases by `use the ? symbol`. IMO, incomplete output is not a critical error in this case. Better, than aborting.

• File flashrom.c:

  • Patch Set #5, Line 948: if (bustype & (1 << i))

    Looks good! I was a bit confused where is the code, but realised it's only in the comment for now, n […]

    Done

To view, visit change 73039. To unsubscribe, or for help writing mail filters, visit settings.