Attention is currently required from: Felix Singer, Alan Green, Angel Pons, Michael Niewöhner.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57810 )
Change subject: [RFC] [WIP] ft2232_spi: reintroduce generic GPIOL control
......................................................................
Patch Set 6:
(2 comments)
Patchset:
PS6:
Generally, I'd prefer a much more explicit interface, e.g.
gpiol[0-3]=[CHL]
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/57810/comment/913577e3_2a52094a
PS2, Line 530: /* * * * * * * * * * * * * * * * * * * * * * * * * * *
: * REQUEST FOR COMMENTS: 'C' could replace `csgpiol` *
: * * * * * * * * * * * * * * * * * * * * * * * * * * */
: case 'C':
: cs_bits |= 1 << gpiol_pin;
: pindir |= 1 << gpiol_pin;
: break;
:
I like it.
Sounds good. It would also allow us to make the two interfaces mutually
exclusive. We could also show a deprecation warning for `csgpiol` and
maybe drop it in the future.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57810
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3989f0f9596c090de52dca67183b1363dae59d3a
Gerrit-Change-Number: 57810
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Alan Green
avg@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Thu, 23 Sep 2021 11:20:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Alan Green
avg@google.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment