Attention is currently required from: Felix Singer, Alan Green, Angel Pons, Michael Niewöhner.
2 comments:
Patchset:
Generally, I'd prefer a much more explicit interface, e.g.
gpiol[0-3]=[CHL]
File ft2232_spi.c:
/* * * * * * * * * * * * * * * * * * * * * * * * * * *
* REQUEST FOR COMMENTS: 'C' could replace `csgpiol` *
* * * * * * * * * * * * * * * * * * * * * * * * * * */
case 'C':
cs_bits |= 1 << gpiol_pin;
pindir |= 1 << gpiol_pin;
break;
I like it.
Sounds good. It would also allow us to make the two interfaces mutually
exclusive. We could also show a deprecation warning for `csgpiol` and
maybe drop it in the future.
To view, visit change 57810. To unsubscribe, or for help writing mail filters, visit settings.