Change in flashrom[master]: dummyflasher.c: Extract params processing into a separate function

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Nico Huber, Namyoon Woo, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54748 )

Change subject: dummyflasher.c: Extract params processing into a separate function
......................................................................

Patch Set 4:

(1 comment)

File dummyflasher.c:

https://review.coreboot.org/c/flashrom/+/54748/comment/3d00e9ce_4f9c0323 
PS4, Line 834: 		return 0;
> nit: I understand that it will eventually go to dummy_init_out because data->emu_chip == EMULATE_NON […]

Yes, returning 0 implying 'ok' case, and this is exactly it - not emulating any flash chip is ok case. There is also a comment /* Nothing else to do */ which means it is ok case, all done we can return.

The lines below 925-929 are handling an error case, when dummy is asked to emulate a chip, but the chip is not recognised (invalid chip).

I agree it could be done better, I also spend some time reading this code. But I would do further improvements in separate patch.