Attention is currently required from: Nico Huber, Namyoon Woo, Angel Pons.

View Change

1 comment:

• File dummyflasher.c:

  • Patch Set #4, Line 834: return 0;

    nit: I understand that it will eventually go to dummy_init_out because data->emu_chip == EMULATE_NON […]

    Yes, returning 0 implying 'ok' case, and this is exactly it - not emulating any flash chip is ok case. There is also a comment /* Nothing else to do */ which means it is ok case, all done we can return.

    The lines below 925-929 are handling an error case, when dummy is asked to emulate a chip, but the chip is not recognised (invalid chip).

    I agree it could be done better, I also spend some time reading this code. But I would do further improvements in separate patch.

To view, visit change 54748. To unsubscribe, or for help writing mail filters, visit settings.