Attention is currently required from: Brian Norris.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79060?usp=email )
Change subject: fmap: Update major/minor version check ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/79060/comment/58eb0f9d_06d27983 : PS2, Line 9: It's not valid to separately check the major and minor versions. The : proper minor check would be something like: : : if (fmap->ver_major == FMAP_VER_MAJOR && : fmap->ver_minor > FMAP_VER_MINOR) Brian, thank you so much for lots of details and links, this is really cool! I thought more about it, and I think the patch is fine, please don't drop it :)
However, I found one gem in cbfstool code , which is a comment for the `is_valid_fmap` function,
/* Make a best-effort assessment if the given fmap is real */
If you could add this comment to the functions, that would be it! Thank you!
I still think it's bad to leave flashrom as it is
This is so nice of you, I appreciate a lot!