Attention is currently required from: Brian Norris.
Patch set 2:Code-Review +1
View Change
1 comment:
Commit Message:
Patch Set #2, Line 9:
It's not valid to separately check the major and minor versions. The
proper minor check would be something like:
if (fmap->ver_major == FMAP_VER_MAJOR &&
fmap->ver_minor > FMAP_VER_MINOR)
Brian, thank you so much for lots of details and links, this is really cool!
I thought more about it, and I think the patch is fine, please don't drop it :)
However, I found one gem in cbfstool code , which is a comment for the `is_valid_fmap` function,
/* Make a best-effort assessment if the given fmap is real */
If you could add this comment to the functions, that would be it! Thank you!
I still think it's bad to leave flashrom as it is
This is so nice of you, I appreciate a lot!
To view, visit change 79060. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I984835579d3b257a2462906f1f5091b179891bd0
Gerrit-Change-Number: 79060
Gerrit-PatchSet: 2
Gerrit-Owner: Brian Norris <briannorris@chromium.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Hsuan-ting Chen <roccochen@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Hsuan Ting Chen <roccochen@chromium.org>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Brian Norris <briannorris@chromium.org>
Gerrit-Comment-Date: Fri, 01 Mar 2024 08:35:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Brian Norris <briannorris@chromium.org>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-MessageType: comment