Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69620 )
Change subject: tests: Add selfcheck to unit tests ......................................................................
Patch Set 8:
(14 comments)
File tests/selfcheck.c:
https://review.coreboot.org/c/flashrom/+/69620/comment/8d0f9f14_4229ce35 PS7, Line 40: programmer row
programmer entry
Done
https://review.coreboot.org/c/flashrom/+/69620/comment/58eea079_bb8d1d61 PS7, Line 68: assert_table(chip->bustype != BUS_NONE, "chip bustype is BUS_NONE", i, : chip->name);
make one line
I had my clang-format set to 96 chars, but now I see flashrom likes 112 chars. fixed
https://review.coreboot.org/c/flashrom/+/69620/comment/b72c8b15_59355dab PS7, Line 74: {
You can add `(void)state; /* unused */` in the beginning here. […]
Done
https://review.coreboot.org/c/flashrom/+/69620/comment/e8418d19_5ae70345 PS7, Line 87: /* Blocks with zero size are bugs in flashchips.c. */ : /* Blocks with zero size are bugs in flashchips.c. */
Same line repeats twice?
Done
https://review.coreboot.org/c/flashrom/+/69620/comment/3d28afce_f56c8996 PS7, Line 89: if (eraser.eraseblocks[i].count : && !eraser.eraseblocks[i].size) {
make if condition on one line
Done
https://review.coreboot.org/c/flashrom/+/69620/comment/a4f70619_d5d01b1f PS7, Line 91: fail_msg( : "Flash chip %s erase function " : "%zu region %zu has size 0",
make one line (out of 91-93)
Done
https://review.coreboot.org/c/flashrom/+/69620/comment/dbbac0d2_e900949e PS7, Line 97: if (!eraser.eraseblocks[i].count : && eraser.eraseblocks[i].size) {
make if condition on one line
Done
https://review.coreboot.org/c/flashrom/+/69620/comment/790d3b36_9bc137ea PS7, Line 99: fail_msg( : "Flash chip %s erase function " : "%zu region %zu has count 0",
make one line (out of 99-101)
Done
https://review.coreboot.org/c/flashrom/+/69620/comment/8b6691fc_d8d797b4 PS7, Line 135:
remove empty new line
Done
https://review.coreboot.org/c/flashrom/+/69620/comment/7fb9031b_c903ded5 PS7, Line 136: fail_msg( : "Flash chip %s erase function " : "%zu and %zu are identical.",
make one line (out of 136-138)
Done
https://review.coreboot.org/c/flashrom/+/69620/comment/19ab723e_193eb06f PS7, Line 143: fail_msg( : "Flash chip %s erase function %zu is not " : "in order",
make one line (out of 143-145)
Done
https://review.coreboot.org/c/flashrom/+/69620/comment/90dee401_7976b64e PS7, Line 170: fail_msg("Board enable for %s %s is misdefined.\n", b->vendor_name, : b->board_name);
make one line
Done
File tests/tests.h:
https://review.coreboot.org/c/flashrom/+/69620/comment/5499c9af_7133b932 PS7, Line 90: _tables
The file name is `selfcheck. […]
Done
File tests/well_formed_tables.c:
https://review.coreboot.org/c/flashrom/+/69620/comment/1f4eb368_a59e995e PS6, Line 83: SKIP_TEST
not done :P
sorry! clang-format overrode me
-
Evan Benn (Code Review)