Attention is currently required from: Felix Singer, Thomas Heijligen, Anastasia Klimchuk.
14 comments:
File tests/selfcheck.c:
Patch Set #7, Line 40: programmer row
programmer entry
Done
assert_table(chip->bustype != BUS_NONE, "chip bustype is BUS_NONE", i,
chip->name);
make one line
I had my clang-format set to 96 chars, but now I see flashrom likes 112 chars. fixed
You can add `(void)state; /* unused */` in the beginning here. […]
Done
/* Blocks with zero size are bugs in flashchips.c. */
/* Blocks with zero size are bugs in flashchips.c. */
Same line repeats twice?
Done
if (eraser.eraseblocks[i].count
&& !eraser.eraseblocks[i].size) {
make if condition on one line
Done
fail_msg(
"Flash chip %s erase function "
"%zu region %zu has size 0",
make one line (out of 91-93)
Done
if (!eraser.eraseblocks[i].count
&& eraser.eraseblocks[i].size) {
make if condition on one line
Done
fail_msg(
"Flash chip %s erase function "
"%zu region %zu has count 0",
make one line (out of 99-101)
Done
remove empty new line
Done
fail_msg(
"Flash chip %s erase function "
"%zu and %zu are identical.",
make one line (out of 136-138)
Done
fail_msg(
"Flash chip %s erase function %zu is not "
"in order",
make one line (out of 143-145)
Done
fail_msg("Board enable for %s %s is misdefined.\n", b->vendor_name,
b->board_name);
make one line
Done
File tests/tests.h:
Patch Set #7, Line 90: _tables
The file name is `selfcheck. […]
Done
File tests/well_formed_tables.c:
Patch Set #6, Line 83: SKIP_TEST
not done :P
sorry! clang-format overrode me
To view, visit change 69620. To unsubscribe, or for help writing mail filters, visit settings.