Attention is currently required from: Evan Benn.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67720 )
Change subject: writeprotect: Add some debug logging if wp_verify fails ......................................................................
Patch Set 4:
(1 comment)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/67720/comment/8b547e31_e8fecb68 PS4, Line 175: ret = FLASHROM_WP_ERR_VERIFY_FAILED; Hold'up, doesn't this change also behavior as well as add debug messages? Because previously you would get a early return however now the loop will continue until the terminal register count before returning the verify_failed err code.
Because the commit message is insufficient I actually didn't see that nuance before, is that a problem now? The commit message should have more details in future Evan and not cram in these subtle changes in the same commit.