Attention is currently required from: Evan Benn.

View Change

1 comment:

• File writeprotect.c:

  • Patch Set #4, Line 175: ret = FLASHROM_WP_ERR_VERIFY_FAILED;

    Hold'up, doesn't this change also behavior as well as add debug messages? Because previously you would get a early return however now the loop will continue until the terminal register count before returning the verify_failed err code.

    Because the commit message is insufficient I actually didn't see that nuance before, is that a problem now? The commit message should have more details in future Evan and not cram in these subtle changes in the same commit.

To view, visit change 67720. To unsubscribe, or for help writing mail filters, visit settings.