[M] Change in flashrom[master]: ichspi.c: Read chip ID and use it to populate `flash->chip`

[Edward O'Callaghan (Code Review)]

Attention is currently required from: Subrata Banik, Angel Pons, Nikolai Artemiev.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69195 )

Change subject: ichspi.c: Read chip ID and use it to populate `flash->chip`
......................................................................

Patch Set 3:

(2 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/69195/comment/e1c22adb_bd3df837 
PS3, Line 21:  FIX: w,E
downstream also has https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/refs/hea...
> Looks like it's trying to do SPI erase instead of hwseq now

how did you surmise this?

What is the output with `-VV` ?

File ichspi.c:

https://review.coreboot.org/c/flashrom/+/69195/comment/37c2b09b_b76e2a12 
PS2, Line 1486: flash->chip->tested = entry->tested;
> Wouldn't it be better to keep this and delete the line that overwrites it? […]

Well as long as CB:69842 isn't re-introduced.