Attention is currently required from: Subrata Banik, Angel Pons, Nikolai Artemiev.
View Change
2 comments:
Commit Message:
Patch Set #3, Line 21: FIX: w,E
downstream also has https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/refs/heads/master/opaque_statusreg.c
Looks like it's trying to do SPI erase instead of hwseq now
how did you surmise this?
What is the output with `-VV` ?
File ichspi.c:
Patch Set #2, Line 1486: flash->chip->tested = entry->tested;
Wouldn't it be better to keep this and delete the line that overwrites it? […]
Well as long as CB:69842 isn't re-introduced.
To view, visit change 69195. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ia408e1e45dc6f53c0934afd6558e301abfa48ee6
Gerrit-Change-Number: 69195
Gerrit-PatchSet: 3
Gerrit-Owner: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Subrata Banik <subratabanik@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Subrata Banik <subratabanik@google.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Tue, 29 Nov 2022 00:09:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan <quasisec@chromium.org>
Comment-In-Reply-To: Nikolai Artemiev <nartemiev@google.com>
Gerrit-MessageType: comment