Attention is currently required from: Simon Buhrow, Aarya.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c:Add a function to get list of sectors that need erasing ......................................................................
Patch Set 56:
(5 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/b31605e7_78f2abc7 PS56, Line 1203: { `layout[function_index].layout_list[block_num]` as a intermediate in the function pre-amble would assist in readability.
https://review.coreboot.org/c/flashrom/+/65844/comment/c064a402_5fd2e245 PS56, Line 1204: ) : { `) {`
https://review.coreboot.org/c/flashrom/+/65844/comment/ff1e9b56_9b793ede PS56, Line 1214: } : else { `} else {`
https://review.coreboot.org/c/flashrom/+/65844/comment/e149cb03_38070fc9 PS56, Line 1220: r( nit: `for (`
https://review.coreboot.org/c/flashrom/+/65844/comment/0bb8e741_227c3c75 PS56, Line 1225: (sub_block_end - sub_block_start + 1)/2 hmm, maybe good to use a const intermediate here for clarity.