Attention is currently required from: Simon Buhrow, Aarya.

View Change

5 comments:

• File flashrom.c:

  • Patch Set #56, Line 1203: {

    `layout[function_index].layout_list[block_num]` as a intermediate in the function pre-amble would assist in readability.

  • Patch Set #56, Line 1204:

    )
    	{
    

    `) {`

  • Patch Set #56, Line 1214:

    	}
    	else {
    

    `} else {`

  • Patch Set #56, Line 1220: r(

    nit: `for (`

  • Patch Set #56, Line 1225: (sub_block_end - sub_block_start + 1)/2

    hmm, maybe good to use a const intermediate here for clarity.

To view, visit change 65844. To unsubscribe, or for help writing mail filters, visit settings.