Attention is currently required from: Edward O'Callaghan, Liam Flaherty, Nikolai Artemiev.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68364 )
Change subject: debug_raiden_spi: Remove fixme with explanation ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File raiden_debug_spi.c:
https://review.coreboot.org/c/flashrom/+/68364/comment/770a5942_8765a5bd PS1, Line 354: // rather than looking for a device with a specific vid:pid.
I have two thoughts on how to address the FIXME. […]
Either approach seems fine. But if you want to go with `1.`, please use C-style comments for consistency with the rest of the file:
``` /* * Table is empty as raiden_debug_spi matches against connected USB * devices, rather than looking for a device with a specific vid:pid. */ ```
Also changed the line wrapping so that both lines have about the same length. It's not a rule/guideline in our coding style, but it looks better 😄
-
Angel Pons (Code Review)