Attention is currently required from: Edward O'Callaghan, Liam Flaherty, Nikolai Artemiev.

Patch set 1:Code-Review +1

View Change

1 comment:

• File raiden_debug_spi.c:

  • Patch Set #1, Line 354: // rather than looking for a device with a specific vid:pid.

    I have two thoughts on how to address the FIXME. […]

    Either approach seems fine. But if you want to go with `1.`, please use C-style comments for consistency with the rest of the file:

    ```
    /*
     * Table is empty as raiden_debug_spi matches against connected USB
     * devices, rather than looking for a device with a specific vid:pid.
     */
    ```

    Also changed the line wrapping so that both lines have about the same length. It's not a rule/guideline in our coding style, but it looks better 😄

To view, visit change 68364. To unsubscribe, or for help writing mail filters, visit settings.