Attention is currently required from: Nicholas Chin, Paul Menzel, ZhiYuanNJ.
Anastasia Klimchuk has posted comments on this change by ZhiYuanNJ. ( https://review.coreboot.org/c/flashrom/+/82193?usp=email )
Change subject: ch347_spi: Add driver support for CH347F packaging ......................................................................
Patch Set 11:
(4 comments)
Patchset:
PS11: ZhiYuanNJ thank you so much for your work! I have two small comments, but that would be the last ones.
PS11:
The current code looks fine to me, and my CH347T still seems to work fine with it (I'm assuming ZhiY […]
Ah okay, got it. I usually have a quick look before submitting anyway. By the way, you review was really good!
File ch347_spi.c:
https://review.coreboot.org/c/flashrom/+/82193/comment/28f5b8e0_3e113581?usp... : PS11, Line 330: Could you please return back these two lines? (330 and 332) It's easier to read with some spacing between logical blocks.
https://review.coreboot.org/c/flashrom/+/82193/comment/1a12aa9c_a2f1a161?usp... : PS11, Line 70: /* TODO: Set this depending on the mode */ I guess this comment can be removed? Thank you for fixing the TODO.