Attention is currently required from: Nicholas Chin, Paul Menzel, ZhiYuanNJ.

View Change

4 comments:

• Patchset:

  • Patch Set #11:

    ZhiYuanNJ thank you so much for your work! I have two small comments, but that would be the last ones.

  • Patch Set #11:

    The current code looks fine to me, and my CH347T still seems to work fine with it (I'm assuming ZhiY […]

    Ah okay, got it. I usually have a quick look before submitting anyway. By the way, you review was really good!

• File ch347_spi.c:

  • Patch Set #11, Line 330:

    Could you please return back these two lines? (330 and 332)
    It's easier to read with some spacing between logical blocks.

  • Patch Set #11, Line 70: /* TODO: Set this depending on the mode */

    I guess this comment can be removed? Thank you for fixing the TODO.

To view, visit change 82193. To unsubscribe, or for help writing mail filters, visit settings.