Change in flashrom[staging]: chispet_enable: Add support for C620-series Lewisburg PCH

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/20922 )

Change subject: chispet_enable: Add support for C620-series Lewisburg PCH
......................................................................


Patch Set 4:

(1 comment)

https://review.coreboot.org/#/c/20922/4/ich_descriptors.c
File ich_descriptors.c:

https://review.coreboot.org/#/c/20922/4/ich_descriptors.c@292
PS4, Line 292: 	    desc->component.FLILL1 == 0) {
Just realized that you changed parentheses here. Which is wrong.
Now, `FLILL1 == 0` is checked on older platforms too and suffices
to say "No forbidden opcodes".

Maybe it becomes clearer if we invert the condition (and switch
bodies):

    if (desc->component.FLILL != 0 ||
        ((cs == CHIPSET_100_SERIES_SUNRISE_POINT || cs == CHIPSET_C620_SERIES_LEWISBURG) &&
         desc->component.FLILL1 != 0)) {
            ...
    } else {
            msg_pdbg2("No forbidden opcodes.\n");
    }



-- 
To view, visit https://review.coreboot.org/20922
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I96c89bc28bdfcd953229c17679f2c28f8b874d0b
Gerrit-Change-Number: 20922
Gerrit-PatchSet: 4
Gerrit-Owner: David Hendricks <[e-mail]>
Gerrit-Reviewer: David Hendricks <[e-mail]>
Gerrit-Reviewer: Nico Huber <[e-mail]>
Gerrit-Reviewer: Paul Menzel <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Comment-Date: Mon, 21 Aug 2017 22:01:26 +0000
Gerrit-HasComments: Yes