Nico Huber has posted comments on this change. ( https://review.coreboot.org/20922 )
Change subject: chispet_enable: Add support for C620-series Lewisburg PCH ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/#/c/20922/4/ich_descriptors.c File ich_descriptors.c:
https://review.coreboot.org/#/c/20922/4/ich_descriptors.c@292 PS4, Line 292: desc->component.FLILL1 == 0) { Just realized that you changed parentheses here. Which is wrong. Now, `FLILL1 == 0` is checked on older platforms too and suffices to say "No forbidden opcodes".
Maybe it becomes clearer if we invert the condition (and switch bodies):
if (desc->component.FLILL != 0 || ((cs == CHIPSET_100_SERIES_SUNRISE_POINT || cs == CHIPSET_C620_SERIES_LEWISBURG) && desc->component.FLILL1 != 0)) { ... } else { msg_pdbg2("No forbidden opcodes.\n"); }