Nico Huber posted comments on this change.

Patch set 4:

(1 comment)

File ich_descriptors.c:
- Patch Set #4, Line 292: desc->component.FLILL1 == 0) {
  Just realized that you changed parentheses here. Which is wrong.
  Now, `FLILL1 == 0` is checked on older platforms too and suffices
  to say "No forbidden opcodes".
  Maybe it becomes clearer if we invert the condition (and switch
  bodies):
```
    if (desc->component.FLILL != 0 ||
        ((cs == CHIPSET_100_SERIES_SUNRISE_POINT || cs == CHIPSET_C620_SERIES_LEWISBURG) &&
         desc->component.FLILL1 != 0)) {
            ...
    } else {
            msg_pdbg2("No forbidden opcodes.\n");
    }
```

To view, visit change 20922. To unsubscribe, visit settings.