Miklós Márton has posted comments on this change. ( https://review.coreboot.org/25683 )
Change subject: Add support for National Instruments USB-845x devices ......................................................................
Patch Set 6: Code-Review+1
(7 comments)
https://review.coreboot.org/#/c/25683/2/Makefile File Makefile:
https://review.coreboot.org/#/c/25683/2/Makefile@943 PS2, Line 943: : ifeq ($(CONFIG_CH341A_SPI), yes) : FEATURE_CFLAGS += -D'CONFIG_CH341A_SPI=1' : PROGRAMMER_OBJS += ch341a_spi.o
If there is no reasonable way to probe for this path, I would prefer […]
Done
https://review.coreboot.org/#/c/25683/2/Makefile@948 PS2, Line 948: endif
How is it licensed? If it's not GPLv2 compatible, should we print a […]
Done
https://review.coreboot.org/#/c/25683/2/Makefile@948 PS2, Line 948: endif
I have not find an explicit license for the NI 845x, but a txt file in the installation folder links […]
Done
https://review.coreboot.org/#/c/25683/2/Makefile@948 PS2, Line 948: endif
I didn't mean to warn anybody of NI's wrath but ours. flashrom authors […]
Done
https://review.coreboot.org/#/c/25683/2/Makefile@1349 PS2, Line 1349:
spurious space
Done
https://review.coreboot.org/#/c/25683/3/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/25683/3/flashrom.c@417 PS3, Line 417: { : .name = "ni845x_spi", : .type = OTHER, // choose other because NI-845x uses own USB implementation : .devs.note = "National Instruments USB-845x\n", : .init = ni845x_spi_init, : .map_flash_region = fallback_map, : .unmap_flash_region = fallback_unmap, : .delay = internal_delay, : },
Please use tabs for indentation
Done
https://review.coreboot.org/#/c/25683/2/ni845x_spi.c File ni845x_spi.c:
https://review.coreboot.org/#/c/25683/2/ni845x_spi.c@8 PS2, Line 8: * the Free Software Foundation; either version 2 of the License, or
Please do not restrict the code to version 2 unless you really […]
Done
-
Miklós Márton (Code Review)