Patch set 6:Code-Review +1
7 comments:
ifeq ($(CONFIG_CH341A_SPI), yes)
FEATURE_CFLAGS += -D'CONFIG_CH341A_SPI=1'
PROGRAMMER_OBJS += ch341a_spi.o
If there is no reasonable way to probe for this path, I would prefer […]
Done
Patch Set #2, Line 948: endif
How is it licensed? If it's not GPLv2 compatible, should we print a […]
Done
Patch Set #2, Line 948: endif
I have not find an explicit license for the NI 845x, but a txt file in the installation folder links […]
Done
Patch Set #2, Line 948: endif
I didn't mean to warn anybody of NI's wrath but ours. flashrom authors […]
Done
spurious space
Done
{
.name = "ni845x_spi",
.type = OTHER, // choose other because NI-845x uses own USB implementation
.devs.note = "National Instruments USB-845x\n",
.init = ni845x_spi_init,
.map_flash_region = fallback_map,
.unmap_flash_region = fallback_unmap,
.delay = internal_delay,
},
Please use tabs for indentation
Done
Patch Set #2, Line 8: * the Free Software Foundation; either version 2 of the License, or
Please do not restrict the code to version 2 unless you really […]
Done
To view, visit change 25683. To unsubscribe, or for help writing mail filters, visit settings.