Attention is currently required from: Nico Huber, Michał Żygowski, Jonathan Zhang, Angel Pons. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57793 )
Change subject: ich_descriptors: Add explicit checks for all chipsets ......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57793/comment/c40a41b3_3ff2c415 PS1, Line 9: CB:55651
Please reference merged commits by their commit hash, e.g. […]
Done
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/57793/comment/ce10add0_f3071c18 PS1, Line 962: warn_peculiar_desc(content->ICCRIBA > 0x34, "C620 series");
Another case,
Done
https://review.coreboot.org/c/flashrom/+/57793/comment/03a33642_4c10e4c1 PS1, Line 965: warn_peculiar_desc(content->ICCRIBA != 0x31, "100 series");
and another one. Basically, if there is an expression given as the first […]
Good point about `warn_if` - I've removed that as well.
https://review.coreboot.org/c/flashrom/+/57793/comment/d9ee735d_504a9f51 PS1, Line 968: if (content->ICCRIBA != 0x34) : msg_pwarn("Unknown flash descriptor, assuming 300 series compatibility.\n"); here too