Attention is currently required from: Nico Huber, Michał Żygowski, Jonathan Zhang, Angel Pons.

View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 9: CB:55651

    Please reference merged commits by their commit hash, e.g. […]

    Done

• File ich_descriptors.c:

  • Patch Set #1, Line 962: warn_peculiar_desc(content->ICCRIBA > 0x34, "C620 series");

    Another case,

    Done

  • Patch Set #1, Line 965: warn_peculiar_desc(content->ICCRIBA != 0x31, "100 series");

    and another one. Basically, if there is an expression given as the first […]

    Good point about `warn_if` - I've removed that as well.

  • Patch Set #1, Line 968:

    		if (content->ICCRIBA != 0x34)
    			msg_pwarn("Unknown flash descriptor, assuming 300 series compatibility.\n");
    

    here too

To view, visit change 57793. To unsubscribe, or for help writing mail filters, visit settings.