Change in ...flashrom[master]: flashchips.c: Make .tested lines consistent

List overview All Threads
Download

newer

older

Change in ...flashrom[master]:...

Change in flashrom[master]: Add...

Alan Green (Code Review)

3 Jul 2019 3 Jul '19

7:36 a.m.

Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/33998

Change subject: flashchips.c: Make .tested lines consistent ......................................................................

flashchips.c: Make .tested lines consistent

As per comments on https://review.coreboot.org/c/flashrom/+/33833/, make placement of spaces in .tested attributes with literal definitions consistent.

Signed-off-by: Alan Green avg@google.com Change-Id: I18118f9f1e858547170fda8412bf6769f5cdcf53 --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/98/33998/1

diff --git a/flashchips.c b/flashchips.c index 629fedb..35735d6 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2523,7 +2523,7 @@ .total_size = 512, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = {.probe = NT, .read = NT, .erase = NT, .write = BAD }, + .tested = {.probe = NT, .read = NT, .erase = NT, .write = BAD}, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = @@ -3440,7 +3440,7 @@ .total_size = 64, .page_size = 0, /* unused */ .feature_bits = 0, - .tested = {.probe = OK, .read = OK, .erase = BAD, .write = BAD }, + .tested = {.probe = OK, .read = OK, .erase = BAD, .write = BAD}, .probe = probe_jedec, /* FIXME! */ .probe_timing = TIMING_ZERO, .block_erasers =

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Edward O'Callaghan (Code Review)

3 Jul 3 Jul

8:57 a.m.

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33998 )

Change subject: flashchips.c: Make .tested lines consistent ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/flashrom/+/33998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18118f9f1e858547170fda8412bf6769f5cdcf53 Gerrit-Change-Number: 33998 Gerrit-PatchSet: 1 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 03 Jul 2019 06:57:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Angel Pons (Code Review)

4 Jul 4 Jul

11:43 a.m.

New subject: Change in flashrom[master]: flashchips.c: Make .tested lines consistent

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33998 )

Change subject: flashchips.c: Make .tested lines consistent ......................................................................

Patch Set 3: Code-Review+1

Shouldn't this go before CB:33931?

-- To view, visit https://review.coreboot.org/c/flashrom/+/33998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18118f9f1e858547170fda8412bf6769f5cdcf53 Gerrit-Change-Number: 33998 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jul 2019 09:43:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

1:30 p.m.

New subject: Change in flashrom[master]: flashchips.c: Make .tested lines consistent

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33998 )

Change subject: flashchips.c: Make .tested lines consistent ......................................................................

Patch Set 3: Code-Review-1

There should be spaces, imho. If in doubt, ask checkpatch.

-- To view, visit https://review.coreboot.org/c/flashrom/+/33998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18118f9f1e858547170fda8412bf6769f5cdcf53 Gerrit-Change-Number: 33998 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Thu, 04 Jul 2019 11:30:08 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Alan Green (Code Review)

5 Jul 5 Jul

7:54 a.m.

New subject: Change in flashrom[master]: flashchips.c: Make .tested lines consistent

Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33998 )

Change subject: flashchips.c: Make .tested lines consistent ......................................................................

Patch Set 3:

...

Patch Set 3: Code-Review-1

There should be spaces, imho. If in doubt, ask checkpatch.

checkpatch.pl appears to be OK with no spaces between open brace and ".".

-- To view, visit https://review.coreboot.org/c/flashrom/+/33998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18118f9f1e858547170fda8412bf6769f5cdcf53 Gerrit-Change-Number: 33998 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 05 Jul 2019 05:54:38 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Nico Huber (Code Review)

10:13 a.m.

New subject: Change in flashrom[master]: flashchips.c: Make .tested lines consistent

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/33998 )

Change subject: flashchips.c: Make .tested lines consistent ......................................................................

Patch Set 3: -Code-Review

...

Patch Set 3:

...
Patch Set 3: Code-Review-1

There should be spaces, imho. If in doubt, ask checkpatch.

checkpatch.pl appears to be OK with no spaces between open brace and ".".

TIL. It seems to assume a line break anyway... which we don't want to add.

-- To view, visit https://review.coreboot.org/c/flashrom/+/33998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18118f9f1e858547170fda8412bf6769f5cdcf53 Gerrit-Change-Number: 33998 Gerrit-PatchSet: 3 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Fri, 05 Jul 2019 08:13:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

6 Jul 6 Jul

12:48 a.m.

New subject: Change in flashrom[master]: flashchips.c: Make .tested lines consistent

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/33998 )

Change subject: flashchips.c: Make .tested lines consistent ......................................................................

flashchips.c: Make .tested lines consistent

As per comments on https://review.coreboot.org/c/flashrom/+/33833/, make placement of spaces in .tested attributes with literal definitions consistent.

Signed-off-by: Alan Green avg@google.com Change-Id: I18118f9f1e858547170fda8412bf6769f5cdcf53 Reviewed-on: https://review.coreboot.org/c/flashrom/+/33998 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M flashchips.c 1 file changed, 2 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, but someone else must approve Edward O'Callaghan: Looks good to me, approved

diff --git a/flashchips.c b/flashchips.c index 4dd9d77..7f31c30 100644 --- a/flashchips.c +++ b/flashchips.c @@ -2523,7 +2523,7 @@ .total_size = 512, .page_size = 256, .feature_bits = FEATURE_WRSR_WREN, - .tested = {.probe = NT, .read = NT, .erase = NT, .write = BAD }, + .tested = {.probe = NT, .read = NT, .erase = NT, .write = BAD}, .probe = probe_spi_rdid, .probe_timing = TIMING_ZERO, .block_erasers = @@ -3440,7 +3440,7 @@ .total_size = 64, .page_size = 0, /* unused */ .feature_bits = 0, - .tested = {.probe = OK, .read = OK, .erase = BAD, .write = BAD }, + .tested = {.probe = OK, .read = OK, .erase = BAD, .write = BAD}, .probe = probe_jedec, /* FIXME! */ .probe_timing = TIMING_ZERO, .block_erasers =

-- To view, visit https://review.coreboot.org/c/flashrom/+/33998 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I18118f9f1e858547170fda8412bf6769f5cdcf53 Gerrit-Change-Number: 33998 Gerrit-PatchSet: 4 Gerrit-Owner: Alan Green avg@google.com Gerrit-Reviewer: Alan Green avg@google.com Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1997

days inactive

1999

days old

flashrom-gerrit@flashrom.org

6 comments

4 participants

tags (0)

participants (4)

Alan Green (Code Review)
Angel Pons (Code Review)
Edward O'Callaghan (Code Review)
Nico Huber (Code Review)