Patch Set 3:
Patch Set 3: Code-Review-1
There should be spaces, imho. If in doubt, ask checkpatch.
checkpatch.pl appears to be OK with no spaces between open brace and ".".
TIL. It seems to assume a line break anyway... which we don't want to add.
Patch set 3:-Code-Review
View Change
To view, visit change 33998. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I18118f9f1e858547170fda8412bf6769f5cdcf53
Gerrit-Change-Number: 33998
Gerrit-PatchSet: 3
Gerrit-Owner: Alan Green <avg@google.com>
Gerrit-Reviewer: Alan Green <avg@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Edward O'Callaghan <quasisec@chromium.org>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 05 Jul 2019 08:13:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment