Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66684 )
Change subject: flashrom.c: create is_internal_programmer() helper ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
Patchset:
PS6: I am wondering about testing.
The branch on writing can be tested with running internal and non-internal (dummy).
The other branch with emergency and non-emergency help message, is it possible to run it with dummy? I can try thinking if a unit test can be implemented for it. The case of "emergency and non-emergency help message" is an interesting example, because it can be hard to repro on a real hardware, but can be decently tested via unit test (emulating broken hardware). I am very open to ideas. It is not just for this one patch, having the unit test covering [non]emergency help message is a good investment for a long-term.
-
Anastasia Klimchuk (Code Review)