Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Patch set 6:Code-Review +1
1 comment:
Patchset:
I am wondering about testing.
The branch on writing can be tested with running internal and non-internal (dummy).
The other branch with emergency and non-emergency help message, is it possible to run it with dummy? I can try thinking if a unit test can be implemented for it.
The case of "emergency and non-emergency help message" is an interesting example, because it can be hard to repro on a real hardware, but can be decently tested via unit test (emulating broken hardware).
I am very open to ideas. It is not just for this one patch, having the unit test covering [non]emergency help message is a good investment for a long-term.
To view, visit change 66684. To unsubscribe, or for help writing mail filters, visit settings.