Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, Christian Walter, Stefan Reinauer, Edward O'Callaghan, David Hendricks, Deomid "rojer" Ryabkov, Tim Chu.
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57589 )
Change subject: Revert "Add support for Intel Emmitsburg PCH"
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Hi David, as per https://doc.coreboot.org/getting_started/gerrit_guidelines.html,
please provide a concrete recommendation here.
1. Explicitly check for Ibex Peak instead of relying on dubious default behavior: CB:57580
2. Start using `==` to check ISL/PSL values, like I've done in CB:57581.
As Angel pointed out, item 2 by itself should be sufficient in this case if we don't want the default behavior, which is to assume Ibex Peak, to change. However, since Ibex Peak was introduced in 2009 and has been obsolete for years we probably should considering changing the default to something more recent.
What exactly would you like to see
that will fix all the issues related to the merge of an unreviewed, regressing
commit
The patch was reviewed and tested by multiple parties - you were one of them! Your comments didn't contain any useful guidance for how you'd like to see this implemented, nor did you raise any specific, actionable concerns.
We went with the approach that aligned with how the code was already implemented and worked when testing on real hardware.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57589
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4ebb7a931cfa66276df2f762c63e6d092d6b3d5a
Gerrit-Change-Number: 57589
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: David Hendricks
Gerrit-Attention: Deomid "rojer" Ryabkov
rojer9@fb.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Mon, 13 Sep 2021 19:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment