Attention is currently required from: Arthur Heymans, Nico Huber, Jonathan Zhang, Johnny Lin, Christian Walter, Stefan Reinauer, Edward O'Callaghan, David Hendricks, Deomid "rojer" Ryabkov, Tim Chu.

View Change

1 comment:

• Patchset:

  • Patch Set #1:

    Hi David, as per https://doc.coreboot.org/getting_started/gerrit_guidelines.html,
    please provide a concrete recommendation here.

    1. Explicitly check for Ibex Peak instead of relying on dubious default behavior: CB:57580
    2. Start using `==` to check ISL/PSL values, like I've done in CB:57581.

    As Angel pointed out, item 2 by itself should be sufficient in this case if we don't want the default behavior, which is to assume Ibex Peak, to change. However, since Ibex Peak was introduced in 2009 and has been obsolete for years we probably should considering changing the default to something more recent.

    What exactly would you like to see
    that will fix all the issues related to the merge of an unreviewed, regressing
    commit

    The patch was reviewed and tested by multiple parties - you were one of them! Your comments didn't contain any useful guidance for how you'd like to see this implemented, nor did you raise any specific, actionable concerns.

    We went with the approach that aligned with how the code was already implemented and worked when testing on real hardware.

To view, visit change 57589. To unsubscribe, or for help writing mail filters, visit settings.