Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 )
Change subject: [RFC] tests: add test of write protection ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS2: Just to double-check, is this chain going to be on the top of https://review.coreboot.org/c/flashrom/+/58738 ?
And thanks for writing tests! I will do a better review later.
File tests/write_protection.c:
https://review.coreboot.org/c/flashrom/+/59075/comment/abf6a104_e06e4fa9 PS2, Line 2: This file How about a bit shorter name: write_protect.c? Same meaning, less chars. And everyone talking about this feature as "write-protect" anyway.
https://review.coreboot.org/c/flashrom/+/59075/comment/767425d4_90857c9a PS2, Line 101: test_failure Is this 1) a test which is expected to fail 2) or a test which is executing failure scenario? It looks like 2) , in this case it should be test_success.
We don't have currently tests of type 1, however you definitely can intro one if you want.
-
Anastasia Klimchuk (Code Review)