Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk.
3 comments:
Patchset:
Just to double-check, is this chain going to be on the top of https://review.coreboot.org/c/flashrom/+/58738 ?
And thanks for writing tests! I will do a better review later.
File tests/write_protection.c:
Patch Set #2, Line 2: This file
How about a bit shorter name: write_protect.c? Same meaning, less chars. And everyone talking about this feature as "write-protect" anyway.
Patch Set #2, Line 101: test_failure
Is this
1) a test which is expected to fail
2) or a test which is executing failure scenario?
It looks like 2) , in this case it should be test_success.
We don't have currently tests of type 1, however you definitely can intro one if you want.
To view, visit change 59075. To unsubscribe, or for help writing mail filters, visit settings.